Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 6814025: Convert update tool into python for easier hackability (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Convert update tool into python for easier hackability R=bradnelson@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80872

Patch Set 1 #

Total comments: 1

Patch Set 2 : added help #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
A tools/update.py View 1 1 chunk +41 lines, -0 lines 0 comments Download
D tools/update.sh View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-07 20:52:28 UTC) #1
bradn
Where's the rev stuff? http://codereview.chromium.org/6814025/diff/1/tools/update.py File tools/update.py (right): http://codereview.chromium.org/6814025/diff/1/tools/update.py#newcode26 tools/update.py:26: print('\nDoing %s' % instance) you ...
9 years, 8 months ago (2011-04-07 20:54:34 UTC) #2
M-A Ruel
On 2011/04/07 20:54:34, bradn wrote: > Where's the rev stuff? I don't do it automatically ...
9 years, 8 months ago (2011-04-07 20:55:24 UTC) #3
bradn
On Thu, Apr 7, 2011 at 1:55 PM, <maruel@chromium.org> wrote: > On 2011/04/07 20:54:34, bradn ...
9 years, 8 months ago (2011-04-07 20:57:55 UTC) #4
M-A Ruel
On 2011/04/07 20:57:55, bradn wrote: > > But how do you inject the parameter now? ...
9 years, 8 months ago (2011-04-07 21:01:48 UTC) #5
bradn
9 years, 8 months ago (2011-04-07 22:47:07 UTC) #6
LGTM
Sorry read it wrong.

Powered by Google App Engine
This is Rietveld 408576698