-Build configuration for a sample Go application that can be run in Mojo (on Android).

-Build configuration for a sample Go application that can be run in Mojo (on Android).
-README instructions to build the application.

R=asadovsky@gmail.com, jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f22f247422f5ec7015104566e88afcde79368917

[gauthamt, 2014-10-28 18:52:30]

gautham.dorai@gmail.com changed reviewers:
+ asadovsky@gmail.com, viettrungluu@chromium.org

[viettrungluu, 2014-10-28 23:54:56]

viettrungluu@chromium.org changed reviewers:
+ jamesr@chromium.org

[viettrungluu, 2014-10-28 23:54:56]

-> jamesr, since this is mostly .gni changes

[jamesr, 2014-10-29 00:07:28]

lgtm

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni
File build/go/rules.gni (right):

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newco...
build/go/rules.gni:64: # Only available on linux for now.
did you mean to assert(is_linux) here ?

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newco...
build/go/rules.gni:77: ":$static_library_name",
nit: for one entry lists we prefer one-line e.g.

deps = [ ":$static_library_name" ]

https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn
File mojo/BUILD.gn (right):

https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn#newcode38
mojo/BUILD.gn:38: deps += [
deps += [ "//mojo/go" ]

can we delete this build arg now?  will the go stuff work for all developers, or
do they have to do additional steps for this stuff to work?

https://codereview.chromium.org/681393002/diff/20001/mojo/go/sample_app/app.go
File mojo/go/sample_app/app.go (right):

https://codereview.chromium.org/681393002/diff/20001/mojo/go/sample_app/app.g...
mojo/go/sample_app/app.go:4: "log"
is this go fmt'd? i'd expect the tab marker but don't see it, but maybe rietveld
is misleading me

[gauthamt, 2014-10-29 00:22:26]

Thanks for the quick review.

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni
File build/go/rules.gni (right):

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newco...
build/go/rules.gni:64: # Only available on linux for now.
On 2014/10/29 00:07:27, jamesr wrote:
> did you mean to assert(is_linux) here ?

Actually, it works only on android. Changed comments and asserted for
is_android.

https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newco...
build/go/rules.gni:77: ":$static_library_name",
On 2014/10/29 00:07:27, jamesr wrote:
> nit: for one entry lists we prefer one-line e.g.
> 
> deps = [ ":$static_library_name" ]

Done.

https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn
File mojo/BUILD.gn (right):

https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn#newcode38
mojo/BUILD.gn:38: deps += [
On 2014/10/29 00:07:27, jamesr wrote:
> deps += [ "//mojo/go" ]
> 
> can we delete this build arg now?  will the go stuff work for all developers,
or
> do they have to do additional steps for this stuff to work?

They would still need to set go_build_tool which is a pointer to the go binary.

https://codereview.chromium.org/681393002/diff/20001/mojo/go/sample_app/app.go
File mojo/go/sample_app/app.go (right):

https://codereview.chromium.org/681393002/diff/20001/mojo/go/sample_app/app.g...
mojo/go/sample_app/app.go:4: "log"
On 2014/10/29 00:07:27, jamesr wrote:
> is this go fmt'd? i'd expect the tab marker but don't see it, but maybe
rietveld
> is misleading me

Done.

[jamesr, 2014-10-29 00:24:09]

On 2014/10/29 00:22:26, gauthamt wrote:
> https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn#newcode38
> mojo/BUILD.gn:38: deps += [
> On 2014/10/29 00:07:27, jamesr wrote:
> > deps += [ "//mojo/go" ]
> > 
> > can we delete this build arg now?  will the go stuff work for all
developers,
> or
> > do they have to do additional steps for this stuff to work?
> 
> They would still need to set go_build_tool which is a pointer to the go
binary.

Would you mind putting instructions (maybe on the wiki
https://github.com/domokit/mojo/wiki) about how one would go about setting this
up?  I'm interested in seeing how to get this stuff running on the bots as well.

[viettrungluu, 2014-10-29 01:17:52]

viettrungluu@chromium.org changed reviewers:
- viettrungluu@chromium.org

[asadovsky, 2014-10-29 16:25:10]

lgtm

lgtm for Go

[gauthamt, 2014-10-29 16:33:32]

Committed patchset #4 (id:60001) manually as
f22f247422f5ec7015104566e88afcde79368917 (presubmit successful).