Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 681393002: -Build configuration for a sample Go application that can be run in Mojo (on Android). (Closed)

Created:
6 years, 1 month ago by gauthamt
Modified:
6 years, 1 month ago
Reviewers:
jamesr, asadovsky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

-Build configuration for a sample Go application that can be run in Mojo (on Android). -README instructions to build the application. R=asadovsky@gmail.com, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f22f247422f5ec7015104566e88afcde79368917

Patch Set 1 #

Patch Set 2 : README comments. #

Total comments: 8

Patch Set 3 : address review comments. #

Patch Set 4 : Fix tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -26 lines) Patch
M build/go/go.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/go/rules.gni View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M mojo/go/BUILD.gn View 1 chunk +33 lines, -18 lines 0 comments Download
A mojo/go/sample_app/README.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
M mojo/go/sample_app/app.go View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gauthamt
6 years, 1 month ago (2014-10-28 18:52:40 UTC) #2
viettrungluu
-> jamesr, since this is mostly .gni changes
6 years, 1 month ago (2014-10-28 23:54:56 UTC) #4
jamesr
lgtm https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni File build/go/rules.gni (right): https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newcode64 build/go/rules.gni:64: # Only available on linux for now. did ...
6 years, 1 month ago (2014-10-29 00:07:28 UTC) #5
gauthamt
Thanks for the quick review. https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni File build/go/rules.gni (right): https://codereview.chromium.org/681393002/diff/20001/build/go/rules.gni#newcode64 build/go/rules.gni:64: # Only available on ...
6 years, 1 month ago (2014-10-29 00:22:26 UTC) #6
jamesr
On 2014/10/29 00:22:26, gauthamt wrote: > https://codereview.chromium.org/681393002/diff/20001/mojo/BUILD.gn#newcode38 > mojo/BUILD.gn:38: deps += [ > On 2014/10/29 ...
6 years, 1 month ago (2014-10-29 00:24:09 UTC) #7
asadovsky
lgtm lgtm for Go
6 years, 1 month ago (2014-10-29 16:25:10 UTC) #9
gauthamt
6 years, 1 month ago (2014-10-29 16:33:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
f22f247422f5ec7015104566e88afcde79368917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698