Corrected mojo_shell --args-for switch handling

Corrected mojo_shell --args-for switch handling.

BUG=427938
R=davemoore@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fa8e6e24fdcccecb8538080be223981f58825dd5

[hansmuller, 2014-10-28 16:18:41]

hansmuller@chromium.org changed reviewers:
+ davemoore@chromium.org

[hansmuller, 2014-10-28 16:21:21]

PTAL.

[abarth-chromium, 2014-10-28 16:26:10]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-10-28 16:26:11]

https://codereview.chromium.org/681363002/diff/1/mojo/shell/desktop/mojo_main.cc
File mojo/shell/desktop/mojo_main.cc (right):

https://codereview.chromium.org/681363002/diff/1/mojo/shell/desktop/mojo_main...
mojo/shell/desktop/mojo_main.cc:111: };
This looks like a static initializer.  Presumably we don't want static
initializers...  Do we not have a build step that fails when we add one?

[hansmuller, 2014-10-28 16:42:04]

I don't know of a build step that checks for static allocations. I moved this
one.

https://codereview.chromium.org/681363002/diff/1/mojo/shell/desktop/mojo_main.cc
File mojo/shell/desktop/mojo_main.cc (right):

https://codereview.chromium.org/681363002/diff/1/mojo/shell/desktop/mojo_main...
mojo/shell/desktop/mojo_main.cc:111: };
On 2014/10/28 16:26:11, abarth wrote:
> This looks like a static initializer.  Presumably we don't want static
> initializers...  Do we not have a build step that fails when we add one?

The kArgsForSwitches constant is stack allocated now.

[DaveMoore, 2014-10-29 15:31:17]

lgtm

https://codereview.chromium.org/681363002/diff/20001/mojo/shell/desktop/mojo_...
File mojo/shell/desktop/mojo_main.cc (right):

https://codereview.chromium.org/681363002/diff/20001/mojo/shell/desktop/mojo_...
mojo/shell/desktop/mojo_main.cc:178: for(int i = 1; i < argc; i++) {
Nit: space between r and (

[hansmuller, 2014-10-29 16:09:49]

Committed patchset #2 (id:20001) manually as
fa8e6e24fdcccecb8538080be223981f58825dd5 (presubmit successful).

[hansmuller, 2014-10-29 16:12:53]

On 2014/10/29 15:31:17, DaveMoore wrote:
> lgtm
> 
>
https://codereview.chromium.org/681363002/diff/20001/mojo/shell/desktop/mojo_...
> File mojo/shell/desktop/mojo_main.cc (right):
> 
>
https://codereview.chromium.org/681363002/diff/20001/mojo/shell/desktop/mojo_...
> mojo/shell/desktop/mojo_main.cc:178: for(int i = 1; i < argc; i++) {
> Nit: space between r and (

Thanks for the review.  FTR, I did fix the nit, the corrected version is in the
mojo repo.