Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 68133020: Fix dragging supported files to tab strip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing header Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.h ('k') | chrome/browser/ui/views/tabs/tab_strip_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 94b1afe6e78d9571b67b8f56572d853ff002e5f2..eafc48d85649fb0e72ca19472543b6cbf1bcf6c7 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -992,6 +992,11 @@ void TabStrip::StopAnimating(bool layout) {
DoLayout();
}
+void TabStrip::FileSupported(const GURL& url, bool supported) {
+ if (drop_info_.get() && drop_info_->url == url)
+ drop_info_->file_supported = supported;
+}
+
const ui::ListSelectionModel& TabStrip::GetSelectionModel() {
return controller_->GetSelectionModel();
}
@@ -1402,10 +1407,28 @@ void TabStrip::OnDragEntered(const DropTargetEvent& event) {
StopAnimating(true);
UpdateDropIndex(event);
+
+ GURL url;
+ string16 title;
+
+ // Check whether the event data includes supported drop data.
+ if (event.data().GetURLAndTitle(&url, &title) && url.is_valid()) {
+ drop_info_->url = url;
+
+ // For file:// URLs, kick off a MIME type request in case they're dropped.
+ if (url.SchemeIsFile())
+ controller()->CheckFileSupported(url);
+ }
}
int TabStrip::OnDragUpdated(const DropTargetEvent& event) {
+ // Update the drop index even if the file is unsupported, to allow
+ // dragging a file to the contents of another tab.
UpdateDropIndex(event);
+
+ if (!drop_info_->file_supported)
+ return ui::DragDropTypes::DRAG_NONE;
+
return GetDropEffect(event);
}
@@ -1419,13 +1442,17 @@ int TabStrip::OnPerformDrop(const DropTargetEvent& event) {
const int drop_index = drop_info_->drop_index;
const bool drop_before = drop_info_->drop_before;
+ const bool file_supported = drop_info_->file_supported;
// Hide the drop indicator.
SetDropIndex(-1, false);
+ // Do nothing if the file was unsupported or the URL is invalid. The URL may
+ // have been changed after |drop_info_| was created.
GURL url;
string16 title;
- if (!event.data().GetURLAndTitle(&url, &title) || !url.is_valid())
+ if (!file_supported ||
+ !event.data().GetURLAndTitle(&url, &title) || !url.is_valid())
return ui::DragDropTypes::DRAG_NONE;
controller()->PerformDrop(drop_before, drop_index, url);
@@ -2434,7 +2461,8 @@ TabStrip::DropInfo::DropInfo(int drop_index,
views::Widget* context)
: drop_index(drop_index),
drop_before(drop_before),
- point_down(point_down) {
+ point_down(point_down),
+ file_supported(true) {
arrow_view = new views::ImageView;
arrow_view->SetImage(GetDropArrowImage(point_down));
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.h ('k') | chrome/browser/ui/views/tabs/tab_strip_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698