tools/testing/dart/test_suite.dart - Issue 68133017: Remove the --use_browser_controller flag, now that it is always true.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 68133017: Remove the --use_browser_controller flag, now that it is always true. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index 4a043ddd8f0a621e64e1c38727c8f3ca77e6fafd..1c6e185c058384cd49af7b0c895a8db9e8205e92 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -1113,7 +1113,7 @@ class StandardTestSuite extends TestSuite {

contentShellFilename, fullHtmlPath, contentShellOptions,

dartFlags, configurationDir));

} else {

- assert(configuration['use_browser_controller']);

+ // Use the BrowserController to send the test to a browser process.

// This command is not actually run, it is used for reproducing

// the failure.

args = ['tools/testing/dart/launch_browser.dart',

« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »