Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/bots/compiler.py

Issue 68133017: Remove the --use_browser_controller flag, now that it is always true. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
diff --git a/tools/bots/compiler.py b/tools/bots/compiler.py
index b64ed3e2f5c1bc12aa8a4f1aca9969788b7fb28f..7f730cbb5a537fe1d929151a7d45ab764dd932e3 100644
--- a/tools/bots/compiler.py
+++ b/tools/bots/compiler.py
@@ -121,30 +121,6 @@ def TestStepName(name, flags):
flags = [x for x in flags if not '=' in x]
return ('%s tests %s' % (name, ' '.join(flags))).strip()
-# TODO(ricow): remove this once we have browser controller drivers for all
-# supported platforms.
-def UseBrowserController(runtime, system):
- supported_platforms = {
- 'linux': ['ff', 'chromeOnAndroid', 'chrome', 'dartium'],
- 'mac': ['safari', 'chrome', 'dartium'],
- 'windows': ['ie9', 'ie10', 'ff', 'chrome', 'dartium']
- }
- # Platforms that we run on the fyi waterfall only.
- fyi_supported_platforms = {
- 'linux': [],
- 'mac': [],
- 'windows': []
- }
-
- if (runtime in supported_platforms[system]):
- return True
-
- if (os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and
- runtime in fyi_supported_platforms[system]):
- return True
-
- return False
-
IsFirstTestStepCall = True
def TestStep(name, mode, system, compiler, runtime, targets, flags, arch):
@@ -175,8 +151,6 @@ def TestStep(name, mode, system, compiler, runtime, targets, flags, arch):
else:
cmd.extend(['--progress=buildbot', '-v'])
- if UseBrowserController(runtime, system):
- cmd.append('--use_browser_controller')
if runtime == 'safari':
cmd.append('--clear_safari_cache')
« no previous file with comments | « no previous file | tools/test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698