Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: tools/test.dart

Issue 68133017: Remove the --use_browser_controller flag, now that it is always true. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/bots/compiler.py ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env dart 1 #!/usr/bin/env dart
2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
3 // for details. All rights reserved. Use of this source code is governed by a 3 // for details. All rights reserved. Use of this source code is governed by a
4 // BSD-style license that can be found in the LICENSE file. 4 // BSD-style license that can be found in the LICENSE file.
5 5
6 /** 6 /**
7 * This file is the entrypoint of the dart test suite. This suite is used 7 * This file is the entrypoint of the dart test suite. This suite is used
8 * to test: 8 * to test:
9 * 9 *
10 * 1. the dart vm 10 * 1. the dart vm
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 158 }
159 159
160 if (conf['runtime'].startsWith('ie')) { 160 if (conf['runtime'].startsWith('ie')) {
161 // NOTE: We've experienced random timeouts of tests on ie9/ie10. The 161 // NOTE: We've experienced random timeouts of tests on ie9/ie10. The
162 // underlying issue has not been determined yet. Our current hypothesis 162 // underlying issue has not been determined yet. Our current hypothesis
163 // is that windows does not handle the IE processes independently. 163 // is that windows does not handle the IE processes independently.
164 // If we have more than one browser and kill a browser we are seeing 164 // If we have more than one browser and kill a browser we are seeing
165 // issues with starting up a new browser just after killing the hanging 165 // issues with starting up a new browser just after killing the hanging
166 // browser. 166 // browser.
167 maxBrowserProcesses = 1; 167 maxBrowserProcesses = 1;
168 } else if (conf['runtime'].startsWith('safari') && 168 } else if (conf['runtime'].startsWith('safari')) {
169 conf['use_browser_controller']) {
170 // Safari does not allow us to run from a fresh profile, so we can only 169 // Safari does not allow us to run from a fresh profile, so we can only
171 // use one browser. 170 // use one browser.
172 maxBrowserProcesses = 1; 171 maxBrowserProcesses = 1;
173 } else if (conf['runtime'] == 'chrome' && 172 } else if (conf['runtime'] == 'chrome' &&
174 conf['use_browser_controller'] &&
175 Platform.operatingSystem == 'macos') { 173 Platform.operatingSystem == 'macos') {
176 // Chrome on mac results in random timeouts. 174 // Chrome on mac results in random timeouts.
177 maxBrowserProcesses = math.max(1, maxBrowserProcesses ~/ 2); 175 maxBrowserProcesses = math.max(1, maxBrowserProcesses ~/ 2);
178 } 176 }
179 177
180 for (String key in selectors.keys) { 178 for (String key in selectors.keys) {
181 if (key == 'co19') { 179 if (key == 'co19') {
182 testSuites.add(new Co19TestSuite(conf)); 180 testSuites.add(new Co19TestSuite(conf));
183 } else if (conf['runtime'] == 'vm' && key == 'vm') { 181 } else if (conf['runtime'] == 'vm' && key == 'vm') {
184 // vm tests contain both cc tests (added here) and dart tests (added 182 // vm tests contain both cc tests (added here) and dart tests (added
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 void main() { 285 void main() {
288 deleteTemporaryDartDirectories().then((_) { 286 deleteTemporaryDartDirectories().then((_) {
289 var optionsParser = new TestOptionsParser(); 287 var optionsParser = new TestOptionsParser();
290 var configurations = optionsParser.parse(new Options().arguments); 288 var configurations = optionsParser.parse(new Options().arguments);
291 if (configurations != null && configurations.length > 0) { 289 if (configurations != null && configurations.length > 0) {
292 testConfigurations(configurations); 290 testConfigurations(configurations);
293 } 291 }
294 }); 292 });
295 } 293 }
296 294
OLDNEW
« no previous file with comments | « tools/bots/compiler.py ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698