Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 681313005: minidump: Use decltype(object) instead of typeof(object) (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Use decltype(object) instead of typeof(object). TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/78bec65b27f21c4731735b1873775522f5e7fa6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M minidump/minidump_memory_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M minidump/minidump_writable.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-10-28 21:18:11 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-10-28 21:28:16 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-10-28 21:28:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78bec65b27f21c4731735b1873775522f5e7fa6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698