Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 681303005: Make bookmark manager load tests work again. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make bookmark manager load tests work again. Also just update some closure URLs. R=arv@chromium.org TBR=xians@chromium.org,zmo@chromium.org BUG=none Committed: https://crrev.com/af99b7dc18334c3809d3d3ab35e85f329137c407 Cr-Commit-Position: refs/heads/master@{#302123}

Patch Set 1 : asdf #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm_test.html View 3 chunks +31 lines, -35 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_context_test.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/gpu/timeline_test.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/disjoint_range_set_test.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/menu_test.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Dan Beam
https://codereview.chromium.org/681303005/diff/90006/chrome/browser/resources/bookmark_manager/js/bmm_test.html File chrome/browser/resources/bookmark_manager/js/bmm_test.html (left): https://codereview.chromium.org/681303005/diff/90006/chrome/browser/resources/bookmark_manager/js/bmm_test.html#oldcode57 chrome/browser/resources/bookmark_manager/js/bmm_test.html:57: callbacks = {} sharing a global context no longer ...
6 years, 1 month ago (2014-10-30 03:10:29 UTC) #11
arv (Not doing code reviews)
LGTM
6 years, 1 month ago (2014-10-30 08:39:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681303005/90006
6 years, 1 month ago (2014-10-30 17:40:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21286)
6 years, 1 month ago (2014-10-30 17:46:31 UTC) #16
Dan Beam
TBR=xians for content/browser/resources/media TBR=zmo for content/browser/resources/gpu just URL fixes in manual tests (current URL 404s)
6 years, 1 month ago (2014-10-30 18:55:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681303005/90006
6 years, 1 month ago (2014-10-30 18:56:50 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:90006)
6 years, 1 month ago (2014-10-30 19:04:19 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:05:10 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af99b7dc18334c3809d3d3ab35e85f329137c407
Cr-Commit-Position: refs/heads/master@{#302123}

Powered by Google App Engine
This is Rietveld 408576698