Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 681223002: [turbofan] Improve typed lowering for JSToBoolean. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typed lowering for JSToBoolean. - JSToBoolean(x:string) => BooleanNot(NumberEqual(x.length, #0)) - JSToBoolean(phi(x1,...,xn):primitive) => phi(JSToBoolean(x1),...,JSToBoolean(xn)) TEST=cctest,mjsunit/asm/do-while,mjsunit/boolean,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -11 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +32 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +6 lines, -2 lines 0 comments Download
A test/mjsunit/asm/do-while.js View 1 chunk +30 lines, -0 lines 0 comments Download
M test/mjsunit/boolean.js View 1 chunk +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +5 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 6 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-10-28 08:29:27 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-10-28 08:31:55 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-10-28 08:34:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698