Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 681213002: GN: Remove content/app -> mojo/application_manager dep (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Remove content/app -> mojo/application_manager dep This dependency doesn't exist in the gyp build and doesn't appear to be used. Committed: https://crrev.com/5c8274db40827d96b66493ac513b888cba152997 Cr-Commit-Position: refs/heads/master@{#301666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 1 month ago (2014-10-28 06:17:14 UTC) #2
jam
lgtm
6 years, 1 month ago (2014-10-28 17:12:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681213002/1
6 years, 1 month ago (2014-10-28 17:41:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 18:28:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 18:29:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c8274db40827d96b66493ac513b888cba152997
Cr-Commit-Position: refs/heads/master@{#301666}

Powered by Google App Engine
This is Rietveld 408576698