Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(409)

Issue 6812041: Refactor monitor_reconfigure to stop using system("xrandr"). (Closed)

Created:
7 years, 10 months ago by marcheu
Modified:
7 years, 9 months ago
Reviewers:
bleung1, Benson Leung
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Refactor monitor_reconfigure to stop using system("xrandr"). This removes the blinking on monitor plug/unplug. This also avoids crashes we get on intel because of vsync bugs. Change-Id: I04ad539a66ba7db1786a4c5d0d4eb7638e99cdd1 BUG=None. TEST=Plug in a second screen, check that things display on the external screen. Unplug the screen, check that things come back on the internal lcd. Review URL: http://codereview.chromium.org/6732013 (cherry picked from commit 88f70bf3bb95e36b65c8a84efd015da30308ba61) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0e7b6bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -147 lines) Patch
M monitor_reconfigure_main.h View 1 chunk +27 lines, -14 lines 0 comments Download
M monitor_reconfigure_main.cc View 3 chunks +99 lines, -54 lines 0 comments Download
M resolution_selector.h View 4 chunks +19 lines, -9 lines 0 comments Download
M resolution_selector.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M resolution_selector_test.cc View 3 chunks +61 lines, -57 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marcheu
Backport from ToT
7 years, 10 months ago (2011-04-08 02:00:39 UTC) #1
Benson Leung
7 years, 10 months ago (2011-04-08 04:45:18 UTC) #2
On 2011/04/08 02:00:39, marcheu wrote:
> Backport from ToT

LGTM.

Powered by Google App Engine
This is Rietveld 408576698