Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 6812037: GTK: A first *very* rough cut at a global menu. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
8 years, 11 months ago
Reviewers:
dbarth4, Evan Stade
CC:
chromium-reviews, Evan Martin
Visibility:
Public.

Description

GTK: Implement rough global menu support behind an about:flags flag. This is a super early first cut of global menu support. It works by creating a GtkMenuBar inside chrome, attaching it to the widget hierarchy and then never showing it. This is sufficient for global menu support to detect the menu, at least on the Natty betas. There's a lot to do before this is considered done. I haven't added Bookmark and History menus, which will need custom handling to keep state up to date with the main window. Some items may need to be moved from one menu to another to fit with Linux conventions. Contains a bunch of new strings for global menu support. These need to go in before the M12 branch point. (I can iterate on the design afterwards; strings need translation.) BUG=30213 TEST=Open a window on Unity. A minimal menu is in the menu bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81170

Patch Set 1 #

Patch Set 2 : More implementation #

Patch Set 3 : Comment #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +71 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 chunks +8 lines, -0 lines 4 comments Download
A chrome/browser/ui/gtk/global_menu_bar.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/ui/gtk/global_menu_bar.cc View 1 1 chunk +255 lines, -0 lines 2 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/models/accelerator_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
Review: estade@ FYI: evan@
9 years ago (2011-04-08 20:55:56 UTC) #1
Evan Stade
can you put this behind a flag until it's more fleshed out? other than that, ...
9 years ago (2011-04-11 19:01:35 UTC) #2
Elliot Glaysher
http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browser_window_gtk.cc File chrome/browser/ui/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browser_window_gtk.cc#newcode1551 chrome/browser/ui/gtk/browser_window_gtk.cc:1551: global_menu_bar_.reset(new GlobalMenuBar(browser_.get(), this)); On 2011/04/11 19:01:35, Evan Stade wrote: ...
9 years ago (2011-04-11 23:18:52 UTC) #3
Evan Stade
http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browser_window_gtk.cc File chrome/browser/ui/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/6812037/diff/2006/chrome/browser/ui/gtk/browser_window_gtk.cc#newcode1551 chrome/browser/ui/gtk/browser_window_gtk.cc:1551: global_menu_bar_.reset(new GlobalMenuBar(browser_.get(), this)); On 2011/04/11 23:18:52, Elliot Glaysher wrote: ...
9 years ago (2011-04-11 23:41:34 UTC) #4
dbarth4
It's great to see the first stages of that integration. Let us know if you ...
8 years, 12 months ago (2011-04-12 17:17:34 UTC) #5
Evan Martin
8 years, 12 months ago (2011-04-14 15:43:56 UTC) #6
Rad.

On Tue, Apr 12, 2011 at 10:17 AM,  <dbarth4@gmail.com> wrote:
> It's great to see the first stages of that integration. Let us know if you
> need
> any help or clarifications from the Canonical DX Team in the process.
>
> http://codereview.chromium.org/6812037/
>

Powered by Google App Engine
This is Rietveld 408576698