Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 681173002: Delete WebWaitableEvent (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
ojan, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Delete WebWaitableEvent We don't use this interface. In the future, we can just use the base version directly. R=eseidel@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5a6a038356355e5cdc504169264e33e10c85b5b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -143 lines) Patch
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -13 lines 0 comments Download
D sky/engine/public/platform/WebWaitableEvent.h View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 04:28:28 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-28 04:35:14 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-28 04:36:10 UTC) #6
abarth-chromium
6 years, 1 month ago (2014-10-28 04:59:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a6a038356355e5cdc504169264e33e10c85b5b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698