Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 681163002: Cleanup: Move some RSA key tests to data files. (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move some RSA key tests to data files. Committed: https://crrev.com/d389348f5b003d8d3c420669e47d3a5b80dc9903 Cr-Commit-Position: refs/heads/master@{#302022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -158 lines) Patch
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 2 chunks +0 lines, -158 lines 0 comments Download
M content/test/data/webcrypto/bad_rsa_keys.json View 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
6 years, 1 month ago (2014-10-28 03:51:22 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-30 01:31:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681163002/1
6 years, 1 month ago (2014-10-30 01:51:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 02:51:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 02:52:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d389348f5b003d8d3c420669e47d3a5b80dc9903
Cr-Commit-Position: refs/heads/master@{#302022}

Powered by Google App Engine
This is Rietveld 408576698