Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 68113028: Lazily format LanguageError messages (fix issue 15069). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 30304)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -1563,6 +1563,10 @@
// Set the object tags.
language_error.set_tags(tags);
+ // Set all non object fields.
+ language_error.set_token_pos(reader->ReadIntptrValue());
+ language_error.set_kind(reader->Read<uint8_t>());
+
// Set all the object fields.
// TODO(5411462): Need to assert No GC can happen here, even though
// allocations may happen.
@@ -1590,6 +1594,10 @@
writer->WriteVMIsolateObject(kLanguageErrorCid);
writer->WriteIntptrValue(writer->GetObjectTags(this));
+ // Write out all the non object fields.
+ writer->WriteIntptrValue(ptr()->token_pos_);
+ writer->Write<uint8_t>(ptr()->kind_);
+
// Write out all the object pointer fields.
SnapshotWriterVisitor visitor(writer);
visitor.VisitPointers(from(), to());
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698