Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: runtime/vm/parser.h

Issue 68113028: Lazily format LanguageError messages (fix issue 15069). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
===================================================================
--- runtime/vm/parser.h (revision 30304)
+++ runtime/vm/parser.h (working copy)
@@ -163,34 +163,6 @@
};
static RawObject* ParseFunctionParameters(const Function& func);
- // Format and print a message with source location.
- // A null script means no source and a negative token_pos means no position.
- static void PrintMessage(const Script& script,
- intptr_t token_pos,
- const char* message_header,
- const char* format, ...) PRINTF_ATTRIBUTE(4, 5);
-
- // Build an error object containing a formatted error or warning message.
- // A null script means no source and a negative token_pos means no position.
- static RawError* FormatError(const Script& script,
- intptr_t token_pos,
- const char* message_header,
- const char* format,
- va_list args);
- static RawError* FormatErrorMsg(const Script& script,
- intptr_t token_pos,
- const char* message_header,
- const char* format, ...)
- PRINTF_ATTRIBUTE(4, 5);
-
- // Same as FormatError, but appends the new error to the 'prev_error'.
- static RawError* FormatErrorWithAppend(const Error& prev_error,
- const Script& script,
- intptr_t token_pos,
- const char* message_header,
- const char* format,
- va_list args);
-
private:
friend class EffectGraphVisitor; // For BuildNoSuchMethodArguments.
@@ -317,7 +289,7 @@
// A null script means no source and a negative token_pos means no position.
static RawString* FormatMessage(const Script& script,
intptr_t token_pos,
- const char* message_header,
+ LanguageError::Kind kind,
const char* format,
va_list args);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698