Lazily format LanguageError messages (fix issue 15069).

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h	(revision 30298)
+++ runtime/vm/raw_object.h	(working copy)
@@ -1092,12 +1092,17 @@
   RAW_HEAP_OBJECT_IMPLEMENTATION(LanguageError);
 
   RawObject** from() {
-    return reinterpret_cast<RawObject**>(&ptr()->message_);
+    return reinterpret_cast<RawObject**>(&ptr()->previous_error_);
   }
+  RawError* previous_error_;  // May be null.
+  RawScript* script_;
   RawString* message_;
+  RawString* formatted_message_;  // Incl. previous error's formatted message.

[siva, 2013/11/15 16:35:51]

Is there any value in storing the formattted message here? I would think we
would generate the formatted message and print it once.

Do you think there is a case were we will repeatedly want the formatted message?

[regis, 2013/11/15 18:27:38]

It is not clear. On the other hand, the cost of storing one pointer in an error
object is not prohibitive.

   RawObject** to() {
-    return reinterpret_cast<RawObject**>(&ptr()->message_);
+    return reinterpret_cast<RawObject**>(&ptr()->formatted_message_);
   }
+  intptr_t token_pos_;  // Source position in script_.
+  int8_t kind_;  // Of type LanguageError::Kind.
 };