Lazily format LanguageError messages (fix issue 15069).

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/cha.h"
 #include "vm/dart_entry.h"
@@ skipping 265 matching lines @@
         EmitInstructionEpilogue(instr);
       }
     }
   }
   set_current_block(NULL);
 }
 
 
 void FlowGraphCompiler::Bailout(const char* reason) {
   const char* kFormat = "FlowGraphCompiler Bailout: %s %s.";
-  const char* function_name = parsed_function().function().ToCString();
+  const Function& function = parsed_function_.function();
+  const char* function_name = function.ToCString();
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
-      LanguageError::New(String::Handle(String::New(chars))));
+      LanguageError::New(Error::Handle(),  // No previous error.
+                         Script::Handle(function.script()),
+                         function.token_pos(),
+                         LanguageError::kError,
+                         String::Handle(String::New(chars))));

[Ivan Posva, 2013/11/15 04:42:13]

ditto

[regis, 2013/11/15 18:27:38]

Done.

   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 intptr_t FlowGraphCompiler::StackSize() const {
   if (is_optimizing_) {
     return flow_graph_.graph_entry()->spill_slot_count();
   } else {
     return parsed_function_.num_stack_locals() +
         parsed_function_.num_copied_params();
@@ skipping 912 matching lines @@
 
   for (int i = 0; i < len; i++) {
     sorted->Add(CidTarget(ic_data.GetReceiverClassIdAt(i),
                           &Function::ZoneHandle(ic_data.GetTargetAt(i)),
                           ic_data.GetCountAt(i)));
   }
   sorted->Sort(HighestCountFirst);
 }
 
 }  // namespace dart