Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: tests/standalone/vmservice/isolate_stacktrace_command_test.dart

Issue 68113019: Filter frames from debugger stack based on visibility rather than "debuggability" (steppability). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: whitespace Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/vmservice/isolate_stacktrace_command_test.dart
diff --git a/tests/standalone/vmservice/isolate_stacktrace_command_test.dart b/tests/standalone/vmservice/isolate_stacktrace_command_test.dart
index 4b4ce79f56d999ad3457eb88140ef936d8f4a71c..e90fdbfd8f3557f508d42862b0a0ea51d2eeeb66 100644
--- a/tests/standalone/vmservice/isolate_stacktrace_command_test.dart
+++ b/tests/standalone/vmservice/isolate_stacktrace_command_test.dart
@@ -13,7 +13,9 @@ class StacktraceTest extends VmServiceRequestHelper {
onRequestCompleted(Map reply) {
Expect.equals('StackTrace', reply['type'], 'Not a StackTrace message.');
- Expect.equals(4, reply['members'].length, 'Stacktrace is wrong length.');
+ Expect.isTrue(4 <= reply['members'].length, 'Stacktrace is wrong length.');
hausner 2013/11/13 23:05:27 What else did you see in the trace? Is it a functi
+ // The number of frames involved in isolate start-up is an implementation
rmacnak 2013/11/13 23:14:34 So actually this should be "message dispatch" not
+ // detail. Only check that we got all the frames for user code.
Expect.equals('a', reply['members'][0]['name']);
Expect.equals('b', reply['members'][1]['name']);
Expect.equals('c', reply['members'][2]['name']);
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698