Fix a 'type-limits' warning in StringSlicer::FindValidBoundaryAfter

ui/gfx/text_elider.cc

Index: ui/gfx/text_elider.cc
diff --git a/ui/gfx/text_elider.cc b/ui/gfx/text_elider.cc
index 1bf85d4936761a22cf3351c4fa0e871abbf518bd..8e12d7f14c95d0bbc2c30f883708fb901960c47a 100644
--- a/ui/gfx/text_elider.cc
+++ b/ui/gfx/text_elider.cc
@@ -147,7 +147,7 @@ size_t StringSlicer::FindValidBoundaryBefore(size_t index) const {
 size_t StringSlicer::FindValidBoundaryAfter(size_t index) const {
   DCHECK_LE(index, text_.length());
   if (index != text_.length())
-    U16_SET_CP_LIMIT(text_.data(), 0, index, text_.length());
+    U16_SET_CP_LIMIT(text_.data(), 0, index, -1);

[Peter Kasting, 2014/10/29 17:33:38]

For safety, this should use c_str() instead of data(), as the former is
guaranteed to be null-terminated and the latter is not.  Passing a negative
length is supposedly only legal with a null-terminated string.

(The macro here doesn't end up caring about such a thing, but it might in the
future.)

[Ben Chan, 2014/10/29 17:36:01]

Done.

   return index;
 }