Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: Source/core/page/FocusController.cpp

Issue 681103003: Fix a bug of sequential focus navigation with <select multiple>, and so on. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/shadow/focus-navigation.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FocusController.cpp
diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp
index 5a24e5e3495ff26a5d3f10c5e957fd57a488ff15..e595789d202ce61f9f4ef7f69d2e7948a475038a 100644
--- a/Source/core/page/FocusController.cpp
+++ b/Source/core/page/FocusController.cpp
@@ -546,7 +546,8 @@ static Node* nextNodeWithGreaterTabIndex(Node* start, int tabIndex)
int winningTabIndex = std::numeric_limits<short>::max() + 1;
Node* winner = nullptr;
for (Node& node : NodeTraversal::startsAt(start)) {
- if (shouldVisit(&node) && node.tabIndex() > tabIndex && node.tabIndex() < winningTabIndex) {
+ int currentTabIndex = adjustedTabIndex(&node);
+ if (shouldVisit(&node) && currentTabIndex > tabIndex && currentTabIndex < winningTabIndex) {
winner = &node;
winningTabIndex = node.tabIndex();
kochi 2014/11/05 17:33:48 Why this isn't currentTabIndex?
tkent 2014/11/05 23:24:00 I think |currentTabIndex| and |node.tabIndex()| ar
}
« no previous file with comments | « LayoutTests/fast/dom/shadow/focus-navigation.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698