tools/auto_bisect/PRESUBMIT.py - Issue 681103002: Update style according to advice from pylint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/auto_bisect/PRESUBMIT.py

Issue 681103002: Update style according to advice from pylint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/auto_bisect/bisect_perf_regression.py » ('j') | tools/auto_bisect/bisect_printer.py » ('J')

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for auto-bisect.	5 """Top-level presubmit script for auto-bisect.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API.	8 details on the presubmit API.

9 """	9 """

10	10

(...skipping 71 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 message = 'Auto-bisect unit tests did not all pass.'	82 message = 'Auto-bisect unit tests did not all pass.'

83 return [output_api.PresubmitError(message)]	83 return [output_api.PresubmitError(message)]

84 return []	84 return []

85	85

86	86

87 def _RunPyLint(input_api, output_api):	87 def _RunPyLint(input_api, output_api):

88 """Runs unit tests for auto-bisect."""	88 """Runs unit tests for auto-bisect."""

89 telemetry_path = os.path.join(	89 telemetry_path = os.path.join(

90 input_api.PresubmitLocalPath(), os.path.pardir, 'telemetry')	90 input_api.PresubmitLocalPath(), os.path.pardir, 'telemetry')

91 mock_path = os.path.join(	91 mock_path = os.path.join(

92 input_api.PresubmitLocalPath(),os.path.pardir, os.path.pardir,	92 input_api.PresubmitLocalPath(), os.path.pardir, os.path.pardir,

93 'third_party', 'pymock')	93 'third_party', 'pymock')

94 tests = input_api.canned_checks.GetPylint(	94 tests = input_api.canned_checks.GetPylint(

95 input_api, output_api, extra_paths_list=[telemetry_path, mock_path])	95 input_api, output_api, extra_paths_list=[telemetry_path, mock_path])

96 return input_api.RunTests(tests)	96 return input_api.RunTests(tests)

97	97

OLD	NEW