Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 681103002: Update style according to advice from pylint. (Closed)

Created:
6 years, 1 month ago by qyearsley
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update style according to advice from pylint. BUG= Committed: https://crrev.com/0f7acf8eda06bc95341a3869a9e51d48ae2a9a99 Cr-Commit-Position: refs/heads/master@{#302139}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M tools/auto_bisect/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/auto_bisect/bisect_perf_regression.py View 10 chunks +13 lines, -13 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 11 chunks +24 lines, -21 lines 0 comments Download
M tools/auto_bisect/bisect_printer.py View 1 chunk +1 line, -1 line 2 comments Download
M tools/auto_bisect/bisect_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/auto_bisect/fetch_build.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
qyearsley
I was just trying to take a look at what tips pylint might give me ...
6 years, 1 month ago (2014-10-27 23:40:21 UTC) #2
RobertoCN
On 2014/10/27 23:40:21, qyearsley wrote: > I was just trying to take a look at ...
6 years, 1 month ago (2014-10-27 23:47:18 UTC) #3
qyearsley
On 2014/10/27 23:47:18, robertocn wrote: > On 2014/10/27 23:40:21, qyearsley wrote: > > I was ...
6 years, 1 month ago (2014-10-28 00:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681103002/1
6 years, 1 month ago (2014-10-28 00:46:16 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-28 00:46:19 UTC) #8
qyearsley
On 2014/10/28 00:46:19, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-10-29 00:36:35 UTC) #9
Sergiy Byelozyorov
lgtm with comments https://codereview.chromium.org/681103002/diff/1/tools/auto_bisect/bisect_printer.py File tools/auto_bisect/bisect_printer.py (right): https://codereview.chromium.org/681103002/diff/1/tools/auto_bisect/bisect_printer.py#newcode40 tools/auto_bisect/bisect_printer.py:40: | / \\ | questions or ...
6 years, 1 month ago (2014-10-30 11:42:45 UTC) #10
qyearsley
https://codereview.chromium.org/681103002/diff/1/tools/auto_bisect/bisect_printer.py File tools/auto_bisect/bisect_printer.py (right): https://codereview.chromium.org/681103002/diff/1/tools/auto_bisect/bisect_printer.py#newcode40 tools/auto_bisect/bisect_printer.py:40: | / \\ | questions or suggestions about bisecting. ...
6 years, 1 month ago (2014-10-30 16:46:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681103002/1
6 years, 1 month ago (2014-10-30 18:06:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 19:56:41 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:58:10 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f7acf8eda06bc95341a3869a9e51d48ae2a9a99
Cr-Commit-Position: refs/heads/master@{#302139}

Powered by Google App Engine
This is Rietveld 408576698