Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 681083002: Removing dead code from CanvasTest (Closed)

Created:
6 years, 1 month ago by Rémi Piotaix
Modified:
6 years, 1 month ago
Reviewers:
Justin Novosad
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove friend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M src/core/SkPictureRecord.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rémi Piotaix
PTAL
6 years, 1 month ago (2014-10-27 22:38:20 UTC) #2
Justin Novosad
https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp File tests/CanvasTest.cpp (left): https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp#oldcode607 tests/CanvasTest.cpp:607: class SkPictureTester { This class is still declared as ...
6 years, 1 month ago (2014-10-28 14:24:24 UTC) #3
Rémi Piotaix
https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp File tests/CanvasTest.cpp (left): https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp#oldcode607 tests/CanvasTest.cpp:607: class SkPictureTester { On 2014/10/28 14:24:24, junov wrote: > ...
6 years, 1 month ago (2014-10-28 14:57:03 UTC) #4
Justin Novosad
On 2014/10/28 14:57:03, Rémi Piotaix wrote: > https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp > File tests/CanvasTest.cpp (left): > > https://codereview.chromium.org/681083002/diff/1/tests/CanvasTest.cpp#oldcode607 ...
6 years, 1 month ago (2014-10-28 16:57:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681083002/20001
6 years, 1 month ago (2014-10-28 18:05:35 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 18:14:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 5ae89d1fa868fbbbfbf866ba46ef7a59687f346a

Powered by Google App Engine
This is Rietveld 408576698