Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68103014: Move some core/platform/graphics/mac files to geometry (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, krit, dsinclair, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move some core/platform/graphics/mac files to geometry BUG=303332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161958

Patch Set 1 #

Patch Set 2 : Fix compile problem #

Patch Set 3 : Export IntSize/IntPoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -545 lines) Patch
M Source/core/core.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/core.gypi View 2 2 chunks +0 lines, -12 lines 0 comments Download
D Source/core/platform/graphics/cg/FloatPointCG.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/platform/graphics/cg/FloatRectCG.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/platform/graphics/cg/FloatSizeCG.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/platform/graphics/cg/IntPointCG.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/platform/graphics/cg/IntRectCG.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/platform/graphics/cg/IntSizeCG.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/platform/graphics/mac/FloatPointMac.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/platform/graphics/mac/FloatRectMac.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/platform/graphics/mac/FloatSizeMac.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/platform/graphics/mac/IntPointMac.mm View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/platform/graphics/mac/IntRectMac.mm View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/platform/graphics/mac/IntSizeMac.mm View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 3 chunks +22 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/platform/geometry/IntPoint.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/geometry/IntSize.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/geometry/cg/FloatPointCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/cg/FloatRectCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/cg/FloatSizeCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/cg/IntPointCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/cg/IntRectCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/cg/IntSizeCG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/FloatPointMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/FloatRectMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/FloatSizeMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/IntPointMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/IntRectMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/geometry/mac/IntSizeMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
Should be a simple move but I don't have access to Mac right now.
7 years, 1 month ago (2013-11-13 15:39:34 UTC) #1
Stephen Chennney
LGTM, assuming the bots agree.
7 years, 1 month ago (2013-11-13 15:45:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/68103014/140001
7 years, 1 month ago (2013-11-13 19:08:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/68103014/140001
7 years, 1 month ago (2013-11-13 21:16:02 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 22:23:48 UTC) #5
Message was sent while issue was closed. 
Change committed as 161958

Powered by Google App Engine
This is Rietveld 408576698