Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 68103011: Adds URL to each peerconnection tab title on webrtc-internals. (Closed)

Created:
7 years, 1 month ago by jiayl
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds URL to each peerconnection tab title on webrtc-internals. Also use bold font for the stats table of the active ICE connection for highlight. BUG=244648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248882

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M content/browser/resources/media/stats_table.js View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/resources/media/tab_view.js View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/webrtc_internals.css View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jiayl
7 years, 1 month ago (2013-11-12 23:42:10 UTC) #1
jiayl
PTAL. Thanks!
7 years, 1 month ago (2013-11-12 23:42:24 UTC) #2
jiayl
On 2013/11/12 23:42:24, jiayl wrote: > PTAL. Thanks! Ping the reviewer.
6 years, 11 months ago (2014-01-08 20:13:48 UTC) #3
jiayl
Ping vrk.
6 years, 11 months ago (2014-01-14 01:46:51 UTC) #4
vrk (LEFT CHROMIUM)
Whoa, sorry for missing this! LGTM
6 years, 10 months ago (2014-02-05 00:48:21 UTC) #5
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 10 months ago (2014-02-05 01:39:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/68103011/70001
6 years, 10 months ago (2014-02-05 03:47:53 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:41:39 UTC) #8
Message was sent while issue was closed.
Change committed as 248882

Powered by Google App Engine
This is Rietveld 408576698