Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5197)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 68103008: Hide IME autocompletion when Omnibox popup closes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a comment. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 4f7987e8781c4eca7042c964abd4cfa4eba2c07b..b6557735fff53b89ce688a59017730593ff8caf0 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -531,9 +531,6 @@ void OmniboxViewViews::UpdatePopup() {
if (!model()->has_focus())
return;
- // Hide the inline autocompletion for IME users.
- location_bar_view_->SetImeInlineAutocompletion(string16());
-
// Prevent inline autocomplete when the caret isn't at the end of the text,
// and during IME composition editing unless
// |kEnableOmniboxAutoCompletionForIme| is enabled.
@@ -586,6 +583,11 @@ bool OmniboxViewViews::OnInlineAutocompleteTextMaybeChanged(
return true;
}
+void OmniboxViewViews::OnInlineAutocompleteTextCleared() {
+ // Hide the inline autocompletion for IME users.
+ location_bar_view_->SetImeInlineAutocompletion(string16());
+}
+
void OmniboxViewViews::OnRevertTemporaryText() {
SelectRange(saved_temporary_selection_);
// We got here because the user hit the Escape key. We explicitly don't call
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698