sky/engine/core/rendering/RenderBoxModelObject.cpp - Issue 681023002: Remove a bunch of frame-level scrolling machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBoxModelObject.cpp

Issue 681023002: Remove a bunch of frame-level scrolling machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBoxModelObject.cpp

diff --git a/sky/engine/core/rendering/RenderBoxModelObject.cpp b/sky/engine/core/rendering/RenderBoxModelObject.cpp

index a9367328d22c3978f3876d6e3914077d04330f57..52450b05b079344cadc76c9836491ebac21b02fa 100644

--- a/sky/engine/core/rendering/RenderBoxModelObject.cpp

+++ b/sky/engine/core/rendering/RenderBoxModelObject.cpp

@@ -883,8 +883,6 @@ void RenderBoxModelObject::calculateBackgroundImageGeometry(const RenderLayerMod

IntRect viewportRect = pixelSnappedIntRect(viewRect());

if (fixedBackgroundPaintsInLocalCoordinates())

viewportRect.setLocation(IntPoint());

- else if (FrameView* frameView = view()->frameView())

- viewportRect.setLocation(IntPoint(frameView->scrollOffsetForFixedPosition()));

if (paintContainer) {

IntPoint absoluteContainerOffset = roundedIntPoint(paintContainer->localToAbsolute(FloatPoint()));