Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: sky/engine/core/frame/FrameView.h

Issue 681023002: Remove a bunch of frame-level scrolling machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/events/MouseRelatedEvent.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.h
diff --git a/sky/engine/core/frame/FrameView.h b/sky/engine/core/frame/FrameView.h
index 29f5903fd71d8e1efecc253dc9386479c158cc5e..2da880c9391182c7c91d1d77ff946a544e62ce3c 100644
--- a/sky/engine/core/frame/FrameView.h
+++ b/sky/engine/core/frame/FrameView.h
@@ -139,7 +139,6 @@ public:
// This is different than visibleContentRect() in that it ignores negative (or overly positive)
// offsets from rubber-banding, and it takes zooming into account.
- LayoutRect viewportConstrainedVisibleContentRect() const;
void viewportConstrainedVisibleContentSizeChanged(bool widthChanged, bool heightChanged);
AtomicString mediaType() const;
@@ -174,9 +173,6 @@ public:
bool hasEverPainted() const { return m_lastPaintTime; }
void setNodeToDraw(Node*);
- // FIXME(sky): Remove
- void paintOverhangAreas(GraphicsContext*, const IntRect& horizontalOverhangArea, const IntRect& verticalOverhangArea, const IntRect& dirtyRect);
-
Color documentBackgroundColor() const;
static double currentFrameTimeStamp() { return s_currentFrameTimeStamp; }
@@ -207,9 +203,6 @@ public:
void setCursor(const Cursor&);
- // FIXME(sky): Remove
- bool scrollbarsCanBeActive() const;
-
// FIXME: Remove this method once plugin loading is decoupled from layout.
void flushAnyPendingPostLayoutTasks();
@@ -248,9 +241,6 @@ public:
bool isActive() const;
- // DEPRECATED: Use viewportConstrainedVisibleContentRect() instead.
- IntSize scrollOffsetForFixedPosition() const;
-
// FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
// passed around the FrameView layout methods can be true while this returns
// false.
@@ -290,8 +280,6 @@ public:
bool scheduleAnimation();
IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) const { return IntRect(IntPoint(), expandedIntSize(frameRect().size())); }
IntSize unscaledVisibleContentSize(IncludeScrollbarsInRect = ExcludeScrollbars) const { return frameRect().size(); }
- IntPoint clampScrollPosition(const IntPoint& scrollPosition) const { return scrollPosition; }
- const IntPoint scrollOrigin() const { return IntPoint(); }
// FIXME(sky): Not clear what values these should return. This is just what they happen to be
// returning today.
bool paintsEntireContents() const { return false; }
@@ -350,9 +338,6 @@ private:
bool wasViewportResized();
void sendResizeEventIfNeeded();
- // FIXME(sky): Remove now that we're not a ScrollView?
- void notifyPageThatContentAreaWillPaint() const;
-
void scrollPositionChanged();
void didScrollTimerFired(Timer<FrameView>*);
« no previous file with comments | « sky/engine/core/events/MouseRelatedEvent.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698