Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 681023002: Remove a bunch of frame-level scrolling machinery. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a bunch of frame-level scrolling machinery. This just removing dead/noop code. No change in behavior. R=abarth@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9a7c8c0629983ca7f05fc06b9049a9b40d8948f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -157 lines) Patch
M sky/engine/core/dom/Touch.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M sky/engine/core/events/MouseRelatedEvent.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 6 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 5 chunks +0 lines, -48 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 4 chunks +2 lines, -22 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/ScrollbarGroup.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ScrollbarGroup.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ojan
6 years, 1 month ago (2014-10-27 19:48:12 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-27 20:06:40 UTC) #5
esprehn
lgtm
6 years, 1 month ago (2014-10-27 20:06:40 UTC) #6
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-27 20:06:41 UTC) #7
esprehn
You're also removing a bunch of position fixed stuff, you might want to mention that.
6 years, 1 month ago (2014-10-27 20:06:46 UTC) #9
ojan
On 2014/10/27 at 20:06:46, esprehn wrote: > You're also removing a bunch of position fixed ...
6 years, 1 month ago (2014-10-27 20:08:50 UTC) #10
ojan
6 years, 1 month ago (2014-10-27 20:10:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a7c8c0629983ca7f05fc06b9049a9b40d8948f5.

Powered by Google App Engine
This is Rietveld 408576698