chrome/browser/ui/views/website_settings/permission_selector_view.cc - Issue 680993004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 680993004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_view.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

index 6a656f5ade157a33c5e4e7f2566576620745b7bb..bfe309fc23f643c1113edaf84eff04efdbf8974f 100644

--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc

+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

@@ -43,19 +43,18 @@ class PermissionMenuButton : public views::MenuButton,

PermissionMenuButton(const base::string16& text,

PermissionMenuModel* model,

bool show_menu_marker);

- virtual ~PermissionMenuButton();

+ ~PermissionMenuButton() override;

// Overridden from views::LabelButton.

- virtual void SetText(const base::string16& text) override;

+ void SetText(const base::string16& text) override;

// Overridden from views::View.

- virtual void GetAccessibleState(ui::AXViewState* state) override;

- virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) override;

+ void GetAccessibleState(ui::AXViewState* state) override;

+ void OnNativeThemeChanged(const ui::NativeTheme* theme) override;

private:

// Overridden from views::MenuButtonListener.

- virtual void OnMenuButtonClicked(View* source,

- const gfx::Point& point) override;

+ void OnMenuButtonClicked(View* source, const gfx::Point& point) override;

PermissionMenuModel* menu_model_; // Owned by |PermissionSelectorView|.

scoped_ptr<views::MenuRunner> menu_runner_;