Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 680993003: Classes: Add basic support for properties (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Add basic support for properties This adds the properties to the prototype and the constructor. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24934

Patch Set 1 #

Total comments: 40

Patch Set 2 : Code review updates #

Patch Set 3 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -18 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 5 chunks +74 lines, -4 lines 0 comments Download
M src/ast.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 2 chunks +234 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
arv (Not doing code reviews)
PTAL
6 years, 1 month ago (2014-10-27 19:17:46 UTC) #2
Dmitry Lomov (no reviews)
Comments https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc#newcode2516 src/arm/full-codegen-arm.cc:2516: __ push(scratch); Add a comment about why it ...
6 years, 1 month ago (2014-10-27 21:37:14 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/680993003/diff/1/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/680993003/diff/1/src/x64/full-codegen-x64.cc#newcode2428 src/x64/full-codegen-x64.cc:2428: Register scratch = rcx; On 2014/10/27 21:37:14, Dmitry Lomov ...
6 years, 1 month ago (2014-10-27 22:20:53 UTC) #4
arv (Not doing code reviews)
Code review updates
6 years, 1 month ago (2014-10-28 09:41:45 UTC) #5
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc#newcode2516 src/arm/full-codegen-arm.cc:2516: __ push(scratch); On 2014/10/27 21:37:13, Dmitry Lomov (chromium) ...
6 years, 1 month ago (2014-10-28 09:42:01 UTC) #6
Dmitry Lomov (no reviews)
lgtm https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc#newcode2516 src/arm/full-codegen-arm.cc:2516: __ push(scratch); On 2014/10/28 09:42:00, arv wrote: > ...
6 years, 1 month ago (2014-10-28 10:34:09 UTC) #7
arv (Not doing code reviews)
git rebase
6 years, 1 month ago (2014-10-28 12:27:42 UTC) #8
arv (Not doing code reviews)
6 years, 1 month ago (2014-10-28 12:43:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698