content/shell/browser/shell_devtools_delegate.h - Issue 680943002: [DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_delegate.h

Issue 680943002: [DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/browser_list_tabcontents_provider.cc ('K') | « content/public/browser/devtools_http_handler_delegate.h ('k') | content/shell/browser/shell_devtools_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_delegate.h

diff --git a/content/shell/browser/shell_devtools_delegate.h b/content/shell/browser/shell_devtools_delegate.h

index 723340d5b0204a829e114da20c331d2b8bedd853..80c44ad1f919e824ccd047424e37039fd87d5de4 100644

--- a/content/shell/browser/shell_devtools_delegate.h

+++ b/content/shell/browser/shell_devtools_delegate.h

@@ -27,8 +27,7 @@ class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {

std::string GetDiscoveryPageHTML() override;

bool BundlesFrontendResources() override;

base::FilePath GetDebugFrontendDir() override;

- scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(

- net::StreamListenSocket::Delegate* delegate,

+ scoped_ptr<net::ServerSocket> CreateSocketForTethering(

std::string* name) override;

DevToolsHttpHandler* devtools_http_handler() {