chromecast/browser/devtools/cast_dev_tools_delegate.cc - Issue 680943002: [DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/cast_dev_tools_delegate.cc

Issue 680943002: [DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/browser_list_tabcontents_provider.cc ('K') | « chromecast/browser/devtools/cast_dev_tools_delegate.h ('k') | content/browser/devtools/devtools_http_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/devtools/cast_dev_tools_delegate.cc

diff --git a/chromecast/browser/devtools/cast_dev_tools_delegate.cc b/chromecast/browser/devtools/cast_dev_tools_delegate.cc

index aaf97bfd8e8a02a2142546b648ebcb035f62e871..622a2a01e9e9c4518df753d37fc464120aceca18 100644

--- a/chromecast/browser/devtools/cast_dev_tools_delegate.cc

+++ b/chromecast/browser/devtools/cast_dev_tools_delegate.cc

@@ -121,11 +121,9 @@ base::FilePath CastDevToolsDelegate::GetDebugFrontendDir() {

return base::FilePath();

}

-scoped_ptr<net::StreamListenSocket>

-CastDevToolsDelegate::CreateSocketForTethering(

- net::StreamListenSocket::Delegate* delegate,

- std::string* name) {

- return scoped_ptr<net::StreamListenSocket>();

+scoped_ptr<net::ServerSocket>

+CastDevToolsDelegate::CreateSocketForTethering(std::string* name) {

+ return scoped_ptr<net::ServerSocket>();

}

// CastDevToolsManagerDelegate -----------------------------------------------