[DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket

[DevTools] Migrate DevToolsHttpHandlerDelegate::CreateSocketForTethering to StreamSocket

BUG=375230
Committed: https://crrev.com/1443f56b6d611ad759f98663bef91044f8de745c
Cr-Commit-Position: refs/heads/master@{#303619}

[vkuzkokov, 2014-10-27 15:43:16]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[vkuzkokov, 2014-10-27 15:43:17]

SocketPump is now mostly a copy of SocketTunnel from
port_forwarding_controller.cc

[dgozman, 2014-10-28 10:06:39]

On 2014/10/27 15:43:17, vkuzkokov wrote:
> SocketPump is now mostly a copy of SocketTunnel from
> port_forwarding_controller.cc

Could you please elaborate on the motivation for this change and difference from
the old implementation?

[vkuzkokov, 2014-10-28 12:30:03]

On 2014/10/28 10:06:39, dgozman wrote:
> On 2014/10/27 15:43:17, vkuzkokov wrote:
> > SocketPump is now mostly a copy of SocketTunnel from
> > port_forwarding_controller.cc
> 
> Could you please elaborate on the motivation for this change and difference
from
> the old implementation?

I wanted to implement CreateSocketForTethering in Webview but unix domain socket
implementation of StreamListenSocket that is used in Chrome for Android is
explicitly deprecated.

 - ServerSocket/StreamSocket have (evidently) different classes for serving and
streaming sockets
 - StreamListenSocket calls DidAccept/DidRead/DidClose on a delegate passed in
constructor, ServerSocket/StreamSocket use Accept/Read/Write with a callback
 - There is no callback for StreamListenSocket::Send

[dgozman, 2014-11-06 14:33:16]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2014-11-06 14:33:17]

API change lgtm. Pavel, please take a look at SocketPump implementation.

https://codereview.chromium.org/680943002/diff/1/chrome/browser/android/dev_t...
File chrome/browser/android/dev_tools_server.cc (right):

https://codereview.chromium.org/680943002/diff/1/chrome/browser/android/dev_t...
chrome/browser/android/dev_tools_server.cc:114: if
(socket->ListenWithAddressAndPort(*name, 0, 10) != net::OK)
nit: make 10 a named constant.

https://codereview.chromium.org/680943002/diff/1/chrome/browser/devtools/brow...
File chrome/browser/devtools/browser_list_tabcontents_provider.cc (right):

https://codereview.chromium.org/680943002/diff/1/chrome/browser/devtools/brow...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:90: if
(socket->ListenWithAddressAndPort("127.0.0.1", port, 10) != net::OK)
nit: make 10 a named constant.

[vkuzkokov, 2014-11-06 16:12:43]

https://codereview.chromium.org/680943002/diff/1/chrome/browser/android/dev_t...
File chrome/browser/android/dev_tools_server.cc (right):

https://codereview.chromium.org/680943002/diff/1/chrome/browser/android/dev_t...
chrome/browser/android/dev_tools_server.cc:114: if
(socket->ListenWithAddressAndPort(*name, 0, 10) != net::OK)
On 2014/11/06 14:33:17, dgozman wrote:
> nit: make 10 a named constant.

Done.

https://codereview.chromium.org/680943002/diff/1/chrome/browser/devtools/brow...
File chrome/browser/devtools/browser_list_tabcontents_provider.cc (right):

https://codereview.chromium.org/680943002/diff/1/chrome/browser/devtools/brow...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:90: if
(socket->ListenWithAddressAndPort("127.0.0.1", port, 10) != net::OK)
On 2014/11/06 14:33:17, dgozman wrote:
> nit: make 10 a named constant.

Done.

[vkuzkokov, 2014-11-10 13:11:03]

vkuzkokov@chromium.org changed reviewers:
+ mmenke@chromium.org

[pfeldman, 2014-11-10 13:13:33]

lgtm

[vkuzkokov, 2014-11-10 13:14:05]

vkuzkokov@chromium.org changed reviewers:
- mmenke@chromium.org

[vkuzkokov, 2014-11-10 14:33:32]

vkuzkokov@chromium.org changed reviewers:
+ dtrainor@chromium.org, gunsch@chromium.org, jam@chromium.org,
mnaganov@chromium.org

[vkuzkokov, 2014-11-10 14:38:39]

PTAL:

jam:
content/public/browser/devtools_http_handler_delegate.h

mnaganov:
android_webview/native/aw_dev_tools_server.cc

dtrainor:
chrome/browser/android/dev_tools_server.cc

gunsch:
chromecast/browser/devtools/cast_dev_tools_delegate.h
chromecast/browser/devtools/cast_dev_tools_delegate.cc

[gunsch, 2014-11-10 16:30:55]

chromecast/ LGTM

[mnaganov (inactive), 2014-11-10 16:37:49]

android_webview LGTM

[David Trainor- moved to gerrit, 2014-11-10 18:53:30]

chrome/browser/android/dev_tools_server.cc LGTM

[jam, 2014-11-11 04:26:17]

lgtm

[vkuzkokov, 2014-11-11 08:54:42]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-11 08:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680943002/20001

[commit-bot: I haz the power, 2014-11-11 09:44:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-11 09:45:37]

Patchset 2 (id:??) landed as
https://crrev.com/1443f56b6d611ad759f98663bef91044f8de745c
Cr-Commit-Position: refs/heads/master@{#303619}