Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Side by Side Diff: build/get_landmines.py

Issue 680923002: Fix ninja "multiple rules" warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clobber to ensure that recipe tests do not break Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/base.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 def print_landmines(): 23 def print_landmines():
24 """ 24 """
25 ALL LANDMINES ARE EMITTED FROM HERE. 25 ALL LANDMINES ARE EMITTED FROM HERE.
26 """ 26 """
27 if (distributor() == 'goma' and platform() == 'win32' and 27 if (distributor() == 'goma' and platform() == 'win32' and
28 builder() == 'ninja'): 28 builder() == 'ninja'):
29 print 'Need to clobber winja goma due to backend cwd cache fix.' 29 print 'Need to clobber winja goma due to backend cwd cache fix.'
30 if platform() == 'android': 30 if platform() == 'android':
31 print 'Clobber: To delete newly generated mojo class files.' 31 print 'Clobber: To delete newly generated mojo class files.'
32 print 'Clobber to ensure that recipe tests do not break (issue 680923002).'
32 if platform() == 'win' and builder() == 'ninja': 33 if platform() == 'win' and builder() == 'ninja':
33 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 34 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
34 if platform() == 'linux' and builder() == 'ninja': 35 if platform() == 'linux' and builder() == 'ninja':
35 print 'Builders switching from make to ninja will clobber on this.' 36 print 'Builders switching from make to ninja will clobber on this.'
36 if platform() == 'mac': 37 if platform() == 'mac':
37 print 'Switching from bundle to unbundled dylib (issue 14743002).' 38 print 'Switching from bundle to unbundled dylib (issue 14743002).'
38 if platform() in ('win', 'mac'): 39 if platform() in ('win', 'mac'):
39 print ('Improper dependency for create_nmf.py broke in r240802, ' 40 print ('Improper dependency for create_nmf.py broke in r240802, '
40 'fixed in r240860.') 41 'fixed in r240860.')
41 if (platform() == 'win' and builder() == 'ninja' and 42 if (platform() == 'win' and builder() == 'ninja' and
(...skipping 19 matching lines...) Expand all
61 print 'Clobber to delete incompatible object binary format with NDK r10c' 62 print 'Clobber to delete incompatible object binary format with NDK r10c'
62 63
63 64
64 def main(): 65 def main():
65 print_landmines() 66 print_landmines()
66 return 0 67 return 0
67 68
68 69
69 if __name__ == '__main__': 70 if __name__ == '__main__':
70 sys.exit(main()) 71 sys.exit(main())
OLDNEW
« no previous file with comments | « base/base.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698