Issue 680923002: Fix ninja "multiple rules" warning.

Issue 680923002: Fix ninja "multiple rules" warning. (Closed)

Created:
6 years, 1 month ago by petrcermak

Modified:
6 years, 1 month ago

Reviewers:
danakj, mkosiba (inactive)

CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix ninja "multiple rules" warning. BUG=427526 Committed: https://crrev.com/297afd0505b111fe9ea65620fca6de4b2f16f234 Cr-Commit-Position: refs/heads/master@{#302064}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/base.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	build/get_landmines.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 13 (5 generated)

petrcermak

Hi, please review this tiny CL which fixes https://code.google.com/p/chromium/issues/detail?id=427526.

6 years, 1 month ago (2014-10-27 16:18:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680923002/60001

6 years, 1 month ago (2014-10-29 16:54:34 UTC) #7

commit-bot: I haz the power

Exceeded time limit waiting for builds to trigger.

6 years, 1 month ago (2014-10-29 22:56:51 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680923002/60001

6 years, 1 month ago (2014-10-30 10:10:46 UTC) #11

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 10:23:17 UTC) #13

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/297afd0505b111fe9ea65620fca6de4b2f16f234
Cr-Commit-Position: refs/heads/master@{#302064}