Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 680913004: Revert of Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths. (Closed)

Created:
6 years, 1 month ago by Fabrice (no longer in Chrome)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths. (patchset #2 id:20001 of https://codereview.chromium.org/633333003/) Reason for revert: This broke Windows bots, see http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/22954/steps/runhooks/logs/stdio There is no pwd command on windows. Original issue's description: > Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths. > > It's not correct to assume that the build directory is two levels below src/. > > BUG=427202 > R=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/dcb216595d483246a0979849f44a993f4d432c7f > Cr-Commit-Position: refs/heads/master@{#301379} TBR=glider@chromium.org,earthdok@chromium.org NOTREECHECKS=true NOTRY=true BUG=427202 Committed: https://crrev.com/96244bb7e54ff3aa129097c6a6e576b8cf0cd3de Cr-Commit-Position: refs/heads/master@{#301382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/common.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Fabrice (no longer in Chrome)
Created Revert of Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths.
6 years, 1 month ago (2014-10-27 16:51:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680913004/1
6 years, 1 month ago (2014-10-27 16:52:57 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 16:52:59 UTC) #4
pasko
lgtm thanks!
6 years, 1 month ago (2014-10-27 16:54:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680913004/1
6 years, 1 month ago (2014-10-27 16:56:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 16:57:51 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:58:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96244bb7e54ff3aa129097c6a6e576b8cf0cd3de
Cr-Commit-Position: refs/heads/master@{#301382}

Powered by Google App Engine
This is Rietveld 408576698