Update ScriptController's resourceInfo() to use V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN()

Update ScriptController's resourceInfo() to use V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN()

Update ScriptController's resourceInfo() to use V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN()
macro instead of toWebCoreString(v8::Handle<v8::Value>), to make sure we abort early
in the event v8::Value::ToString() throws an exception.

R=haraken

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162128

[haraken, 2013-11-15 16:23:10]

LGTM

https://codereview.chromium.org/68073005/diff/1/Source/bindings/v8/ScriptCont...
File Source/bindings/v8/ScriptController.cpp (right):

https://codereview.chromium.org/68073005/diff/1/Source/bindings/v8/ScriptCont...
Source/bindings/v8/ScriptController.cpp:163:
V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringResourceName,
origin.ResourceName(), false);

Is there any code that wants to return other than false? If no, we can drop
'false' from call sites.

I'm thinking about how to refactor these unreadable macros.

V8TRYCATCH => ToNativeValueOrException
V8TRYCATCH_VOID => ToNativeValue
V8TRYCATCH_RETURN => ToNativeValueOrFalse
V8TRYCATCH_FOR_V8STRINGRESOURCE => ToV8StringResourceOrException
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID => ToV8StringResource
V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN => ToV8StringResourceOrFalse

Any better suggestion is welcome :)

[Inactive, 2013-11-15 16:28:48]

https://codereview.chromium.org/68073005/diff/1/Source/bindings/v8/ScriptCont...
File Source/bindings/v8/ScriptController.cpp (right):

https://codereview.chromium.org/68073005/diff/1/Source/bindings/v8/ScriptCont...
Source/bindings/v8/ScriptController.cpp:163:
V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringResourceName,
origin.ResourceName(), false);
On 2013/11/15 16:23:11, haraken wrote:
> 
> Is there any code that wants to return other than false? If no, we can drop
> 'false' from call sites.

Yes, some call sites want to return something else than false, like String() or
v8::Local<v8::Value>(). I think it is best to keep this level of flexibility.

[commit-bot: I haz the power, 2013-11-15 16:29:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68073005/1

[commit-bot: I haz the power, 2013-11-15 18:52:57]

Change committed as 162128