Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 680703002: Remove more frame-level scrolling machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/PinchViewport.cpp ('k') | sky/engine/platform/scroll/ScrollAnimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index 93c9ec88a7b4c83d5c3f3c34c7da05e0ef94b84e..97eec7cb6d3c5b4de5f4d20d1b092e637bc59590 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -408,12 +408,6 @@ void RenderBox::scrollRectToVisible(const LayoutRect& rect, const ScrollAlignmen
// Don't scroll to reveal an overflow layer that is restricted by the -webkit-line-clamp property.
// This will prevent us from revealing text hidden by the slider in Safari RSS.
newRect = layer()->scrollableArea()->exposeRect(rect, alignX, alignY);
- } else if (!parentBox && canBeProgramaticallyScrolled()) {
- if (FrameView* frameView = this->frameView()) {
- LayoutRect viewRect = frameView->visibleContentRect();
- LayoutRect r = ScrollAlignment::getRectToExpose(viewRect, rect, alignX, alignY);
- frameView->setScrollPosition(roundedIntPoint(r.location()));
- }
}
if (frame()->page()->autoscrollController().autoscrollInProgress())
« no previous file with comments | « sky/engine/core/frame/PinchViewport.cpp ('k') | sky/engine/platform/scroll/ScrollAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698