Read contents of test file after getting its absolute path.

chrome/test/remoting/remote_desktop_browsertest.cc

Index: chrome/test/remoting/remote_desktop_browsertest.cc
diff --git a/chrome/test/remoting/remote_desktop_browsertest.cc b/chrome/test/remoting/remote_desktop_browsertest.cc
index b1d5717fcda55ac6b14875e7534da2038b612598..c6c38fb7881121d2d0e15ed996a885b6a0fb730a 100644
--- a/chrome/test/remoting/remote_desktop_browsertest.cc
+++ b/chrome/test/remoting/remote_desktop_browsertest.cc
@@ -826,14 +826,12 @@ void RemoteDesktopBrowserTest::SetUserNameAndPassword(
   // ReadFile instead.
   int64 accounts_file_size;
   base::GetFileSize(accounts_file_path, &accounts_file_size);

[Lambros, 2014/10/27 21:20:50]

Please ASSERT_TRUE() on base::GetFileSize(). If it fails, |accounts_file_size|
will hold garbage.

[anandc, 2014/10/27 22:18:57]

Acknowledged.

-  // There is a compile error on Windows if you use a non-constant array size.
-  // For the test-accounts file, we'll assume a maximum file size of 10K.
-  char buf[10240];
-  ASSERT_FALSE(base::ReadFile(accounts_file_path, buf, accounts_file_size - 1)
-    == -1);
+  scoped_ptr<char[]> file_contents(new char[accounts_file_size]);
+  ASSERT_NE(base::ReadFile(accounts_file_path, file_contents.get(),
+    accounts_file_size), -1);
 
   // Get the root dictionary from the input json file contents.
-  std::string accounts_info(buf);
+  std::string accounts_info(file_contents.get(), accounts_file_size);
   scoped_ptr<base::Value> root(
       base::JSONReader::Read(accounts_info, base::JSON_ALLOW_TRAILING_COMMAS));