Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2943)

Unified Diff: chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h

Issue 680643002: Ensure that the main window does not render as deactivated when the link disambiguation bubble is d… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h
diff --git a/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h b/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h
index 6bc012f6cc7fdb9b3f39b33084870dc849ea3da9..e48dee21b4018776c3d301aa02686381865e7fea 100644
--- a/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h
+++ b/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h
@@ -7,6 +7,7 @@
#include "content/public/browser/web_contents_view_delegate.h"
#include "ui/gfx/geometry/rect.h"
+#include "ui/views/widget/widget.h"
namespace aura {
class Window;
@@ -25,13 +26,15 @@ class LinkDisambiguationPopup {
LinkDisambiguationPopup();
~LinkDisambiguationPopup();
- // Creates and shows the Popup. |zoomed_bitmap| is the scaled-up image of the
- // ambiguous web content. |target_rect| is the original, unzoomed rectangle
- // in DIPs in the coordinate system of |content|. We will convert received
+ // Creates and shows the Popup. |top_level_widget| is the active widget.
+ // |zoomed_bitmap| is the scaled-up image of the ambiguous web content.
+ // |target_rect| is the original, unzoomed rectangle in DIPs in the
+ // coordinate system of |content|. We will convert received
// gestures in the popup to the coordinate system of |content| and as an
// offset within |target_rect|, and then call the |callback| with the
// transformed coordinates GestureEvent.
- void Show(const SkBitmap& zoomed_bitmap,
+ void Show(views::Widget* top_level_widget,
+ const SkBitmap& zoomed_bitmap,
const gfx::Rect& target_rect,
const gfx::NativeView content,
const base::Callback<void(ui::GestureEvent*)>& gesture_cb,
« no previous file with comments | « no previous file | chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698