Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 680643002: Ensure that the main window does not render as deactivated when the link disambiguation bubble is d… (Closed)

Created:
6 years, 1 month ago by ananta
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure that the main window does not render as deactivated when the link disambiguation bubble is displayed. This uses the existing framework in the BubbleDelegate to disable inactive rendering in the active widget when the bubble is displayed, etc. Inactive rendering is enabled when the bubble is dismissed. Changes in this patch are to pass the active widget to the LinkDisambiguationPopup class when it is created to display the bubble. This class then passes the contents view to the actual bubble. BUG=421020 Committed: https://crrev.com/5d4c9226a159f421c17ca3c9b33c5ee692081172 Cr-Commit-Position: refs/heads/master@{#301439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc View 1 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
ananta
6 years, 1 month ago (2014-10-24 23:01:21 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm.
6 years, 1 month ago (2014-10-25 00:29:50 UTC) #3
sky
LGTM https://codereview.chromium.org/680643002/diff/1/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc File chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc (right): https://codereview.chromium.org/680643002/diff/1/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc#newcode60 chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc:60: top_level_widget ? top_level_widget->GetContentsView() : NULL, NULL->nullptr
6 years, 1 month ago (2014-10-25 15:22:43 UTC) #4
ananta
https://codereview.chromium.org/680643002/diff/1/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc File chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc (right): https://codereview.chromium.org/680643002/diff/1/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc#newcode60 chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc:60: top_level_widget ? top_level_widget->GetContentsView() : NULL, On 2014/10/25 15:22:43, sky ...
6 years, 1 month ago (2014-10-27 19:19:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680643002/20001
6 years, 1 month ago (2014-10-27 19:22:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 20:55:56 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:56:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d4c9226a159f421c17ca3c9b33c5ee692081172
Cr-Commit-Position: refs/heads/master@{#301439}

Powered by Google App Engine
This is Rietveld 408576698