linux aura: Fix window activation in some X11 window managers.

linux aura: Fix window activation in some X11 window managers.

Some X11 window managers do not support extended window manager hints (EWMH) like
_NET_ACTIVE_WINDOW. In such cases, instead of trying to set the _NET_ACTIVE_WINDOW
atom on the X11 RootWindow, use XRaiseWindow() to activate a window.

BUG=317856
R=erg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235245

[sadrul, 2013-11-14 04:10:53]

This fixes the referenced bug for me (tested in icewm, ion3, twm, ratpoison).

[Elliot Glaysher, 2013-11-14 18:37:38]

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/x11_desktop_handler.cc (right):

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:69:
reinterpret_cast<unsigned char**>(&atoms));
ui::GetAtomArrayProperty()?

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:90: XClientMessageEvent
xclient;
piman would disprove. He's told me several times to specify the toplevel type.

[sadrul, 2013-11-14 19:06:41]

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/x11_desktop_handler.cc (right):

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:69:
reinterpret_cast<unsigned char**>(&atoms));
On 2013/11/14 18:37:38, Elliot Glaysher wrote:
> ui::GetAtomArrayProperty()?

Done.

https://codereview.chromium.org/68063003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:90: XClientMessageEvent
xclient;
On 2013/11/14 18:37:38, Elliot Glaysher wrote:
> piman would disprove. He's told me several times to specify the toplevel type.

Reverted (I hadn't meant to include this in the CL)

[Elliot Glaysher, 2013-11-14 19:11:24]

lgtm++

https://codereview.chromium.org/68063003/diff/100001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/x11_desktop_handler.cc (right):

https://codereview.chromium.org/68063003/diff/100001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:94: (XEvent*)&xclient);
The c-style cast is still here.

[sadrul, 2013-11-14 19:15:13]

https://codereview.chromium.org/68063003/diff/100001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/x11_desktop_handler.cc (right):

https://codereview.chromium.org/68063003/diff/100001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/x11_desktop_handler.cc:94: (XEvent*)&xclient);
On 2013/11/14 19:11:24, Elliot Glaysher wrote:
> The c-style cast is still here.

Doh! Fixed.

[sadrul, 2013-11-14 22:46:18]

Committed patchset #3 manually as r235245 (presubmit successful).