Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 680583003: Delete ScriptableDocumentParser (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Delete ScriptableDocumentParser There's only one parser: the HTMLDocumentParser. No need for the complex class hierarchy. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d5b2001986fc0a0abbd7afe0e2324850df39fc98

Patch Set 1 #

Patch Set 2 : Sort headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -239 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 3 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.h View 3 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/DocumentFragment.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentFragment.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentParser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
D sky/engine/core/dom/ParserContentPolicy.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/dom/ScriptableDocumentParser.h View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/dom/ScriptableDocumentParser.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
M sky/engine/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/markup.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/editing/markup.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.h View 4 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.cpp View 6 chunks +8 lines, -14 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 5 chunks +14 lines, -12 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +8 lines, -9 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M sky/engine/core/loader/DocumentWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-24 18:00:33 UTC) #1
eseidel
lgtm
6 years, 2 months ago (2014-10-24 18:03:43 UTC) #3
abarth-chromium
6 years, 2 months ago (2014-10-24 18:04:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d5b2001986fc0a0abbd7afe0e2324850df39fc98.

Powered by Google App Engine
This is Rietveld 408576698