Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 680573004: Made ChromeShellSyncTests run alongside the other instrumentation tests. (Closed)

Created:
6 years, 2 months ago by mikecase (-- gone --)
Modified:
6 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Made ChromeShellSyncTests run alongside the other instrumentation tests. The ChromeShellSyncTest tests have been running on some of the chromium-fyi android bots. The tests have passed consistently for several days and I am now moving them to run with the rest of the instrumentation tests. BUG=406538 Committed: https://crrev.com/94c8f1ad3b06bfa488fa263b88b65422c6fceb37 Cr-Commit-Position: refs/heads/master@{#301471}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M build/android/buildbot/bb_device_steps.py View 3 chunks +6 lines, -10 lines 2 comments Download
M build/android/buildbot/bb_run_bot.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mikecase (-- gone --)
Want to get this in on Monday. I'm guessing I'll have to make a recipe ...
6 years, 2 months ago (2014-10-25 00:49:34 UTC) #2
jbudorick
https://codereview.chromium.org/680573004/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/680573004/diff/1/build/android/buildbot/bb_device_steps.py#newcode80 build/android/buildbot/bb_device_steps.py:80: None), Why didn't the device_files folder make the jump?
6 years, 1 month ago (2014-10-27 18:14:09 UTC) #3
mikecase (-- gone --)
https://codereview.chromium.org/680573004/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/680573004/diff/1/build/android/buildbot/bb_device_steps.py#newcode80 build/android/buildbot/bb_device_steps.py:80: None), On 2014/10/27 18:14:09, jbudorick wrote: > Why didn't ...
6 years, 1 month ago (2014-10-27 18:21:39 UTC) #4
jbudorick
lgtm
6 years, 1 month ago (2014-10-27 20:44:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680573004/1
6 years, 1 month ago (2014-10-27 20:48:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/11804)
6 years, 1 month ago (2014-10-27 21:21:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680573004/1
6 years, 1 month ago (2014-10-27 21:37:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:09:45 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:10:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94c8f1ad3b06bfa488fa263b88b65422c6fceb37
Cr-Commit-Position: refs/heads/master@{#301471}

Powered by Google App Engine
This is Rietveld 408576698