Add some more volatile paths.

Add some more volatile paths.

Some clip paths were not marked as volatile, and ending up in the
distance field path renderer when they shouldn't.

BUG=skia:3066
Committed: https://skia.googlesource.com/skia/+/0deb2d9c5d62f8c16fa6049902f9346af735b496

[jvanverth1, 2014-10-24 17:22:24]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com

[jvanverth1, 2014-10-24 17:22:25]

The ones in SkCanvas probably aren't needed, but I added them to be consistent.

[bsalomon, 2014-10-24 17:29:18]

https://codereview.chromium.org/680543002/diff/20001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/680543002/diff/20001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:1551: path.setIsVolatile(true);
If this is coming out of the clipstack and copying copies the bit then maybe we
don't need it here?

https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.cpp:100: path.setIsVolatile(true);
Is it not already volatile since it comes from the clipstack? Same Q for other
paths in this file.

[jvanverth1, 2014-10-24 17:36:30]

https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.cpp:100: path.setIsVolatile(true);
On 2014/10/24 17:29:18, bsalomon wrote:
> Is it not already volatile since it comes from the clipstack? Same Q for other
> paths in this file.

I'm not sure when it would get set as volatile in the clipstack -- wouldn't it
be stored in the heap in that case? And it could also be a rrect.

[jvanverth1, 2014-10-24 18:21:55]

On 2014/10/24 17:36:30, jvanverth1 wrote:
>
https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
https://codereview.chromium.org/680543002/diff/20001/src/gpu/GrClipMaskManage...
> src/gpu/GrClipMaskManager.cpp:100: path.setIsVolatile(true);
> On 2014/10/24 17:29:18, bsalomon wrote:
> > Is it not already volatile since it comes from the clipstack? Same Q for
other
> > paths in this file.
> 
> I'm not sure when it would get set as volatile in the clipstack -- wouldn't it
> be stored in the heap in that case? And it could also be a rrect.

Updated to enforce volatility in the clipstack. PTAL

[bsalomon, 2014-10-24 18:27:36]

lgtm

[jvanverth1, 2014-10-24 18:29:09]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-10-24 18:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680543002/40001

[commit-bot: I haz the power, 2014-10-24 19:41:39]

Committed patchset #3 (id:40001) as 0deb2d9c5d62f8c16fa6049902f9346af735b496