add gm: colorwheel

add gm: colorwheel

BUG=skia:3061
Committed: https://skia.googlesource.com/skia/+/30b83d45a3af444e6868c638d86442c2ea3e20c6

[hal.canary, 2014-10-24 16:36:52]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2014-10-24 16:36:52]

ptal

[mtklein, 2014-10-24 16:47:49]

https://codereview.chromium.org/680533002/diff/1/gm/colorwheel.cpp
File gm/colorwheel.cpp (right):

https://codereview.chromium.org/680533002/diff/1/gm/colorwheel.cpp#newcode33
gm/colorwheel.cpp:33: static void colorwheel(SkCanvas* canvas) {
// Here is why we run this GM: ...

https://codereview.chromium.org/680533002/diff/1/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/680533002/diff/1/gm/gm.h#newcode27
gm/gm.h:27: #define DEF_SIMPLE_GM(F, W, H)                                      
   \
Let's do this like DEF_TEST?

#define DEF_SIMPLE_GM(NAME, CANVAS, W, H)
   class SK_MACRO_CONCAT(NAME, _GM) : public skiagm::GM {
     void onDraw(SkCanvas*) SK_OVERRIDE:
      ....
   };
   DEF_GM(...);
   void SK_MACRO_CONCAT(NAME, _GM)::onDraw(SkCanvas* CANVAS)

https://codereview.chromium.org/680533002/diff/1/tools/Resources.cpp
File tools/Resources.cpp (right):

https://codereview.chromium.org/680533002/diff/1/tools/Resources.cpp#newcode13
tools/Resources.cpp:13: #include "SkData.h"
sort?

[hal.canary, 2014-10-24 17:22:01]

https://codereview.chromium.org/680533002/diff/1/gm/colorwheel.cpp
File gm/colorwheel.cpp (right):

https://codereview.chromium.org/680533002/diff/1/gm/colorwheel.cpp#newcode33
gm/colorwheel.cpp:33: static void colorwheel(SkCanvas* canvas) {
On 2014/10/24 16:47:48, mtklein wrote:
> // Here is why we run this GM: ...

Done.

https://codereview.chromium.org/680533002/diff/1/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/680533002/diff/1/gm/gm.h#newcode27
gm/gm.h:27: #define DEF_SIMPLE_GM(F, W, H)                                      
   \
On 2014/10/24 16:47:48, mtklein wrote:
> Let's do this like DEF_TEST?
> 
> #define DEF_SIMPLE_GM(NAME, CANVAS, W, H)
>    class SK_MACRO_CONCAT(NAME, _GM) : public skiagm::GM {
>      void onDraw(SkCanvas*) SK_OVERRIDE:
>       ....
>    };
>    DEF_GM(...);
>    void SK_MACRO_CONCAT(NAME, _GM)::onDraw(SkCanvas* CANVAS)

Done.

https://codereview.chromium.org/680533002/diff/1/tools/Resources.cpp
File tools/Resources.cpp (right):

https://codereview.chromium.org/680533002/diff/1/tools/Resources.cpp#newcode13
tools/Resources.cpp:13: #include "SkData.h"
On 2014/10/24 16:47:48, mtklein wrote:
> sort?

Done.

[mtklein, 2014-10-24 17:28:44]

lgtm

https://codereview.chromium.org/680533002/diff/20001/gm/colorwheel.cpp
File gm/colorwheel.cpp (right):

https://codereview.chromium.org/680533002/diff/20001/gm/colorwheel.cpp#newcode46
gm/colorwheel.cpp:46: if (GetResourceAsBitmap("color_wheel.png", &bitmap)) {
Might want SkAssertResult in here somewhere?

[hal.canary, 2014-10-24 18:01:14]

https://codereview.chromium.org/680533002/diff/20001/gm/colorwheel.cpp
File gm/colorwheel.cpp (right):

https://codereview.chromium.org/680533002/diff/20001/gm/colorwheel.cpp#newcode46
gm/colorwheel.cpp:46: if (GetResourceAsBitmap("color_wheel.png", &bitmap)) {
On 2014/10/24 17:28:44, mtklein wrote:
> Might want SkAssertResult in here somewhere?

Done.

[hal.canary, 2014-10-24 18:01:21]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-24 18:01:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680533002/40001

[commit-bot: I haz the power, 2014-10-24 18:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 18:14:55]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[hal.canary, 2014-10-24 18:28:19]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-24 18:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680533002/60001

[hal.canary, 2014-10-24 19:46:03]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-24 19:47:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680533002/70001

[hal.canary, 2014-10-24 19:49:46]

Patchset #5 (id:70001) has been deleted

[hal.canary, 2014-10-24 19:50:19]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-24 19:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680533002/80001

[commit-bot: I haz the power, 2014-10-24 21:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 21:22:26]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[hal.canary, 2014-10-26 12:15:41]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-26 12:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680533002/100001

[commit-bot: I haz the power, 2014-10-26 12:23:58]

Committed patchset #6 (id:100001) as 30b83d45a3af444e6868c638d86442c2ea3e20c6