Issue 68053002: Remove config.h from header files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68053002: Remove config.h from header files (Closed)

Created:
7 years, 1 month ago by lgombos

Modified:
7 years, 1 month ago

Reviewers:
eseidel

CC:
blink-reviews, jamesr, krit, dsinclair, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove config.h from header files. According to the coding style config.h should only be included in the implementation to avoid double inclusion. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161698

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -6 lines)			Patch
M	Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/platform/mac/NSScrollerImpDetails.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/ApplicationCacheHostInternal.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

lgombos

This also confused my script for http://code.google.com/p/chromium/issues/detail?id=317231 .

7 years, 1 month ago (2013-11-10 14:43:15 UTC) #1

eseidel

Including config.h was more wrong back in the fastMalloc days, but I think can still ...

7 years, 1 month ago (2013-11-10 22:57:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/68053002/1

7 years, 1 month ago (2013-11-10 22:58:29 UTC) #4

Message was sent while issue was closed.

Change committed as 161698